Skip to content

Conversation

@geospatial-jeff
Copy link
Collaborator

@geospatial-jeff geospatial-jeff commented Aug 2, 2022

Related Issue(s):

Description:
Adds a subclass of starlette's standard CORS middleware w/ defaults set to those recommended by the stac spec. Added the CORS middleware to default set of middleware used by the application.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@captaincoordinates
Copy link
Contributor

I understand why you closed #341 but I think you should consider bringing in those unit tests, as this is currently untested.

@geospatial-jeff
Copy link
Collaborator Author

Will do!

@geospatial-jeff geospatial-jeff merged commit 397acac into master Aug 4, 2022
@geospatial-jeff geospatial-jeff deleted the add-default-cors-middleware branch August 4, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide default CORS middleware

4 participants