fix: use NoDecode for cors origins #313
Merged
+76
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This re-enables the use of
simple,comma,delimted,stringsfrom environment variables forCORS_ORIGINS. Otherwise, the env var syntax needs to be an encoded json string, which is awkward.E.g. without this fix you had to say
CORS_ORIGINS=["http://a.test","http://b.test"]. Now you can sayCORS_ORIGINS=http://a.test,http://b.test, which is how it's described in the CHANGELOG.PR Checklist:
pre-commithooks pass locallymake test)make docs)