use specific ENV ENABLE_TRANSACTIONS_EXTENSIONS for transactions #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrodmn
requested changes
May 13, 2025
Collaborator
hrodmn
left a comment
hrodmn
left a comment
There was a problem hiding this comment.
Looks good but you need to fix the env var name in docker-compose.yml to be ENABLE_TRANSACTIONS_EXTENSIONS.
Just a thought: should we handle the extensions env var and other logic using the pydantic settings rather than reading it in app.py?
Co-authored-by: Henry Rodman <[email protected]>
Member
Author
I though about it but didn't want to change to many things. |
vincentsarago
added a commit
that referenced
this pull request
May 13, 2025
* disable transaction and bulk_transactions extensions by default resolves #231 * enable all extensions in cicd * apply suggestions from review Co-authored-by: Vincent Sarago <[email protected]> * refactor fixtures * remove unused * use specific ENV ENABLE_TRANSACTIONS_EXTENSIONS for transactions (#239) * use specific ENV ENABLE_TRANSACTIONS_EXTENSIONS for transactions * Update docker-compose.yml Co-authored-by: Henry Rodman <[email protected]> --------- Co-authored-by: Henry Rodman <[email protected]> * update changelog --------- Co-authored-by: Vincent Sarago <[email protected]> Co-authored-by: vincentsarago <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.