Adding backwards compatibility for asset indexing #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rch into unique_asset_names
…ch into unique_asset_names
Adding scripts for reindexing existing indexes. Adding tests for serializers.
…ch into unique_asset_names
Collaborator
|
Hi @rhysrevans3, can you split this work into 2 separate prs. I think with testing the optional asset indexing, it's a little tricky because the indexes are created when the container starts. |
Collaborator
Author
|
Hi @jonhealy1 I've removed the serializer tests I will create a new pull request for these. I've not had time to test the new environment variable yet. I'll aim to test it early next week. |
Collaborator
|
@rhysrevans3 Ok great thank you |
Collaborator
Author
|
@jonhealy1 this is ready for review. I've not been able to test the reindexing script with the new datetime indexing as I don't have any indexes using it. |
jonhealy1
approved these changes
Sep 16, 2025
Collaborator
jonhealy1
left a comment
jonhealy1
left a comment
There was a problem hiding this comment.
Nice work thanks @rhysrevans3
YuriZmytrakov
pushed a commit
to YuriZmytrakov/stac-fastapi-elasticsearch-opensearch
that referenced
this pull request
Sep 23, 2025
**Related Issue(s):** - ~stac-utils#425~ - stac-utils#428 **Description:** - Adds flag for indexing assets. - ~Adds tests for serializers.~ - Adds scripts for reindexing for mapping changes. **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [ ] Tests pass (run `make test`) - [ ] Documentation has been updated to reflect changes, if applicable - [ ] Changes are added to the changelog
YuriZmytrakov
pushed a commit
to YuriZmytrakov/stac-fastapi-elasticsearch-opensearch
that referenced
this pull request
Sep 23, 2025
**Related Issue(s):** - ~stac-utils#425~ - stac-utils#428 **Description:** - Adds flag for indexing assets. - ~Adds tests for serializers.~ - Adds scripts for reindexing for mapping changes. **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [ ] Tests pass (run `make test`) - [ ] Documentation has been updated to reflect changes, if applicable - [ ] Changes are added to the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Add unit tests for the ItemSerializer and CollectionSerializer #425Description:
Adds tests for serializers.PR Checklist:
pre-commit run --all-files)make test)