Always generate links for all searches #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Should we have a test for this? |
Collaborator
Author
added |
4 tasks
jonhealy1
reviewed
May 6, 2024
jonhealy1
added a commit
that referenced
this pull request
May 8, 2024
) **Related Issue(s):** - #242 **Merge dependencie(s):** - #241 **Description:** - Paginated search queries now don't return a token on the last page. - Made some fixes to the respective tests. In particular `test_pagination_token_idempotent` had and indentation issue - Improved `execute_search` to make use of `es_response["hits"]["total"]["value"]` **PR Checklist:** - [x] Code is formatted and linted (run `pre-commit run --all-files`) - [x] Tests pass (run `make test`) - [x] Documentation has been updated to reflect changes, if applicable - [x] Changes are added to the changelog --------- Co-authored-by: Jonathan Healy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
linksarray when at the last page of pagination. Healy-Hyperspatial/stac-fastapi-mongo#20Description:
Always generate links for all searches, since now base links are generated on the request and no longer stored.
PR Checklist:
pre-commit run --all-files)make test)