remove db logic from all collections in core.py #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jamesfisher-geo
left a comment
jamesfisher-geo
left a comment
There was a problem hiding this comment.
Nice. Just one question. Does the base_url always have a trailing slash?
| "rel": Relations.self.value, | ||
| "type": MimeTypes.json, | ||
| "href": urljoin(base_url, "collections"), | ||
| "href": f"{base_url}collections", |
Collaborator
There was a problem hiding this comment.
Is there any chance that the self href could be malformed if base_url does not have a trailing slash?
Like https://stac_base_urlcollections
Collaborator
Author
There was a problem hiding this comment.
That's a good point. I guess urljoin probably guarantees the url will be fine either way?
Collaborator
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
Ok nice. Thanks for sharing
jamesfisher-geo
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Removing the es-specific language from core.py makes it easier to use other databases with the api core package in the future.
PR Checklist:
pre-commit run --all-files)make test)