Skip to content

Start MessageListener with ThreadAbstraction.ExecuteThreadLongRunning #2 #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2021
Merged

Start MessageListener with ThreadAbstraction.ExecuteThreadLongRunning #2 #902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c2e969
Fix Thread pool exhaustion due to MessageListener running on ThreadPool
IgorMilavec Nov 22, 2021
01c6a87
Mark long running thread as background
IgorMilavec Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Renci.SshNet/Abstractions/ThreadAbstraction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,17 @@ public static void Sleep(int millisecondsTimeout)

public static void ExecuteThreadLongRunning(Action action)
{
if (action == null)
throw new ArgumentNullException("action");

#if FEATURE_THREAD_TAP
var taskCreationOptions = System.Threading.Tasks.TaskCreationOptions.LongRunning;
System.Threading.Tasks.Task.Factory.StartNew(action, taskCreationOptions);
#else
var thread = new System.Threading.Thread(() => action());
thread.Start();
new System.Threading.Thread(() => action())
{
IsBackground = true
}.Start();
#endif
}

Expand Down
3 changes: 2 additions & 1 deletion src/Renci.SshNet/Session.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,8 @@ public void Connect()
_messageListenerCompleted.Reset();

// Start incoming request listener
ThreadAbstraction.ExecuteThread(() => MessageListener());
// ToDo: Make message pump async, to not consume a thread for every session
ThreadAbstraction.ExecuteThreadLongRunning(() => MessageListener());

// Wait for key exchange to be completed
WaitOnHandle(_keyExchangeCompletedWaitHandle);
Expand Down