Update to MSTest 4 #1721
Open
Update to MSTest 4 #1721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace Execute with ExecuteAsync and fix MSTEST0057 https://learn.microsoft.com/en-us/dotnet/core/testing/mstest-analyzers/mstest0057 (link currently dead)
Fixing this properly would require the tests to respect testContext.CancellationToken. I'm not sure this is worth fixing or how to even do it for the sync methods. https://learn.microsoft.com/en-us/dotnet/core/testing/mstest-analyzers/mstest0045
I assume that parallelization would break a lot of stuff. https://learn.microsoft.com/en-us/dotnet/core/testing/mstest-analyzers/mstest0001
mus65
requested review from
Rob-Hague,
WojciechNagorski and
drieseng
as code owners
|
I think it is a good time to merge this change |
Rob-Hague
reviewed
Oct 28, 2025
There was a problem hiding this comment.
It still suffers from missing console output in the integration tests #1693 (comment):
This branch:
develop:
I found microsoft/testfx#6457 but apparently it is working as intended...
There was a problem hiding this comment.
The changes in this file should be reverted - most of them are explicitly testing ICollection.Contains implementations which is now lost
(I don't think MSTEST0037 really provides much benefit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSTest 4 has quite a few new asserts, analyzers and breaking changes, see https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-mstest-migration-v3-v4 .
Most of these were automatically fixed by the code fixer, see separate commits.
The update also triggered new sonar analyzer warnings, which seems to a bug in sonar, see SonarSource/sonar-dotnet#9767 . I suppressed these for now.