Skip to content

Bump actions/checkout from 4 to 5 #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 22, 2025
+18 −22
Merged

Bump actions/checkout from 4 to 5 #1693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2a6682c
Bump actions/checkout from 4 to 5
dependabot[bot] Sep 2, 2025
2b98614
Bump actions/upload-pages-artifact from 3 to 4
dependabot[bot] Sep 2, 2025
ff9f349
Bump actions/download-artifact from 4 to 5
dependabot[bot] Sep 2, 2025
3728c23
Bump the dependencies group with 5 updates
dependabot[bot] Sep 2, 2025
4288869
Merge remote-tracking branch 'upstream/dependabot/github_actions/acti…
Rob-Hague Sep 22, 2025
4c6ceca
Merge remote-tracking branch 'upstream/dependabot/github_actions/acti…
Rob-Hague Sep 22, 2025
98fb776
fix
Rob-Hague Sep 22, 2025
3988580
Merge branch 'dependabot/nuget/dependencies-c382c502ab' into dependab…
Rob-Hague Sep 22, 2025
860e264
fix locally failing portforwarding tests
Rob-Hague Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0 # needed for Nerdbank.GitVersioning

Expand Down Expand Up @@ -57,7 +57,7 @@ jobs:
runs-on: windows-2025
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0 # needed for Nerdbank.GitVersioning

Expand Down Expand Up @@ -108,7 +108,7 @@ jobs:
runs-on: windows-2025
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0 # needed for Nerdbank.GitVersioning

Expand Down Expand Up @@ -155,7 +155,7 @@ jobs:
- Linux
steps:
- name: Download NuGet Package
uses: actions/download-artifact@v4
uses: actions/download-artifact@v5
with:
name: NuGet Package

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
uses: actions/checkout@v5

- name: Setup Pages
uses: actions/configure-pages@v5
Expand All @@ -37,7 +37,7 @@ jobs:
run: docfx ./docfx/docfx.json

- name: Upload documentation
uses: actions/upload-pages-artifact@v3
uses: actions/upload-pages-artifact@v4
with:
path: './docfx/_site'

Expand Down
12 changes: 6 additions & 6 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,23 @@
<CentralPackageVersionOverrideEnabled>false</CentralPackageVersionOverrideEnabled>
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="BenchmarkDotNet" Version="0.15.2" />
<PackageVersion Include="BenchmarkDotNet" Version="0.15.3" />
<PackageVersion Include="BouncyCastle.Cryptography" Version="2.6.2" />
<PackageVersion Include="coverlet.collector" Version="6.0.4" />
<PackageVersion Include="coverlet.msbuild" Version="6.0.4" />
<PackageVersion Include="GitHubActionsTestLogger" Version="2.4.1" />
<PackageVersion Include="Meziantou.Analyzer" Version="2.0.210" />
<PackageVersion Include="Meziantou.Analyzer" Version="2.0.220" />
<!-- Should stay on LTS .NET releases. -->
<PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.3" />
<PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="9.0.7" />
<PackageVersion Include="MSTest" Version="3.10.0" />
<PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="9.0.9" />
<PackageVersion Include="MSTest" Version="3.9.3" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed a regression in MSTest 3.10 whereby the integration tests console logger output is no longer shown

<PackageVersion Include="Moq" Version="4.20.72" />
<PackageVersion Include="Nerdbank.GitVersioning" Version="3.7.115" />
<PackageVersion Include="PolySharp" Version="1.15.0" />
<PackageVersion Include="SonarAnalyzer.CSharp" Version="10.15.0.120848" />
<PackageVersion Include="StyleCop.Analyzers" Version="1.2.0-beta.556" />
<!-- Should stay on LTS .NET releases. -->
<PackageVersion Include="System.Formats.Asn1" Version="8.0.2" />
<PackageVersion Include="Testcontainers" Version="4.6.0" />
<PackageVersion Include="Testcontainers" Version="4.7.0" />
</ItemGroup>
</Project>
</Project>
16 changes: 6 additions & 10 deletions test/Renci.SshNet.IntegrationTests/SshTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,12 +527,9 @@ public void Ssh_LocalPortForwardingCloseChannels()
{
client.Connect();

var localEndPoint = new IPEndPoint(IPAddress.Loopback, 1225);

for (var i = 0; i < (connectionInfo.MaxSessions + 1); i++)
{
var forwardedPort = new ForwardedPortLocal(localEndPoint.Address.ToString(),
(uint)localEndPoint.Port,
var forwardedPort = new ForwardedPortLocal(IPAddress.Loopback.ToString(),
hostNameAlias,
80);
client.AddForwardedPort(forwardedPort);
Expand All @@ -547,7 +544,8 @@ public void Ssh_LocalPortForwardingCloseChannels()

using HttpClient httpClient = new(handler);

using HttpResponseMessage httpResponse = httpClient.GetAsync("http://" + localEndPoint).Result;
using HttpResponseMessage httpResponse = httpClient.GetAsync(
$"http://{forwardedPort.BoundHost}:{forwardedPort.BoundPort}").Result;

Assert.AreEqual(HttpStatusCode.MovedPermanently, httpResponse.StatusCode);
}
Expand Down Expand Up @@ -583,10 +581,7 @@ public void Ssh_LocalPortForwarding()
{
client.Connect();

var localEndPoint = new IPEndPoint(IPAddress.Loopback, 1225);

var forwardedPort = new ForwardedPortLocal(localEndPoint.Address.ToString(),
(uint)localEndPoint.Port,
var forwardedPort = new ForwardedPortLocal(IPAddress.Loopback.ToString(),
hostNameAlias,
80);
forwardedPort.Exception +=
Expand All @@ -603,7 +598,8 @@ public void Ssh_LocalPortForwarding()

using HttpClient httpClient = new(handler);

using HttpResponseMessage httpResponse = httpClient.GetAsync("http://" + localEndPoint).Result;
using HttpResponseMessage httpResponse = httpClient.GetAsync(
$"http://{forwardedPort.BoundHost}:{forwardedPort.BoundPort}").Result;

Assert.AreEqual(HttpStatusCode.MovedPermanently, httpResponse.StatusCode);
}
Expand Down