Skip to content

Fix for channel session semaphore from thread blocking #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Fix for channel session semaphore from thread blocking #1071

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
106ff50
Merging fix from @clivetong into our own SSH.NET fork
patrick-yates-redgate Jan 18, 2023
a530090
Merging fix from @clivetong into our own SSH.NET fork
patrick-yates-redgate Jan 18, 2023
11673fa
Merge remote-tracking branch 'origin/develop' into develop
patrick-yates-redgate Sep 28, 2023
b0a6ad6
Update Channel to fix AppVeyor failure (field should be readonly)
patrick-yates-redgate Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Renci.SshNet/Channels/Channel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ internal abstract class Channel : IChannel
private uint? _remoteWindowSize;
private uint? _remoteChannelNumber;
private uint? _remotePacketSize;
private ISession _session;
private readonly ISession _session;
private bool _isDisposed;

/// <summary>
Expand Down Expand Up @@ -834,7 +834,6 @@ protected virtual void Dispose(bool disposing)
var session = _session;
if (session != null)
{
_session = null;
session.ChannelWindowAdjustReceived -= OnChannelWindowAdjust;
session.ChannelDataReceived -= OnChannelData;
session.ChannelExtendedDataReceived -= OnChannelExtendedData;
Expand Down