Skip to content

Conversation

ssh24
Copy link
Owner

@ssh24 ssh24 commented Mar 2, 2018

Description

Grad Apps will now allow users to sign-up prior to using the application. This will make sure the system does not depend on third part authentication modules to let users access the system.

Acceptance Criteria

  • Register form
  • Store encrypted credentials into database instead of file
  • Unit tests

@ssh24 ssh24 self-assigned this Mar 2, 2018
@ssh24 ssh24 requested a review from eddyv as a code owner March 2, 2018 22:15
@eddyv
Copy link
Collaborator

eddyv commented Mar 4, 2018

Issues:

  1. App crashes when trying to access a role page that the user is not assigned to.
    ex) Sign up -> Log in -> Roles page -> Type in url for professor page -> CRASH
    we should send them to an oops page or something like that.

  2. For registering we need to check if the email field is of the correct format. We can also definitely condense the form a bit. no need to scroll down. (See image for example)
    image

Side note:
We also need to start working on not locking the user out if the browser closes/user leaves the page.
Also, if the user goes to the homepage and clicks "sign in" and they already signed in it should direct them to the role page not the sign in page

@ssh24 ssh24 force-pushed the master branch 2 times, most recently from d33c22a to ddbd67c Compare April 30, 2018 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants