Skip to content

FIX: request done before all chunks are received #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

FIX: request done before all chunks are received #121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2ffa86
FIX: request done before all chunks are received
jplumi Apr 3, 2024
73f89d0
FIX: onComplete action being invoked twice
jplumi Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Runtime/OpenAIApi.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ private async void DispatchRequest<T>(string path, string method, Action<List<T>
request.SetHeaders(Configuration, ContentType.ApplicationJson);

var asyncOperation = request.SendWebRequest();
bool isDone = false;

do
{
Expand All @@ -124,7 +125,7 @@ private async void DispatchRequest<T>(string path, string method, Action<List<T>

if (value.Contains("[DONE]"))
{
onComplete?.Invoke();
isDone = true;
break;
}

Expand All @@ -144,7 +145,7 @@ private async void DispatchRequest<T>(string path, string method, Action<List<T>

await Task.Yield();
}
while (!asyncOperation.isDone && !token.IsCancellationRequested);
while (!isDone);

onComplete?.Invoke();
}
Expand Down