prioritize JavaCompile.Options.release and Android CompileOptions when parsing an artifact jdk version
#968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when parsing an artifact jdk version There are several methods for setting a JDK version, but the artifacts check plugin is only parsing the lowest priority method. `JavaPluginExtension.targetCompatibility.majorVersion` can be set directly, or via the newer `javaToolchain` functionality. However, in an Android project, the `compileOptions.targetCompatibility` property has a higher priority, and the `options.release` property in a `JavaCompile` task is higher than them both. Prior to these changes, if a JDK version setting was overwritten by the other methods, the plugin wouldn't catch it. Now it will. I also made the decision to change `ArtifactConfig.javaVersion` from a `String` to an `Int`. This is because there's ambiguity when the version is a String and it's representing Java 8. In this case, is the string version just `"8"` or is it `"1.8"`? The different methods report different versions. Just treating the version as an `Int` removes that ambiguity.
rjrjr
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several methods for setting a JDK version, but the artifacts check plugin is only parsing the lowest priority method.
JavaPluginExtension.targetCompatibility.majorVersioncan be set directly, or via the newerjavaToolchainfunctionality. However, in an Android project, thecompileOptions.targetCompatibilityproperty has a higher priority, and theoptions.releaseproperty in aJavaCompiletask is higher than them both.Prior to these changes, if a JDK version setting was overwritten by the other methods, the plugin wouldn't catch it. Now it will.
I also made the decision to change
ArtifactConfig.javaVersionfrom aStringto anInt. This is because there's ambiguity when the version is a String and it's representing Java 8. In this case, is the string version just"8"or is it"1.8"? The different methods report different versions. Just treating the version as anIntremoves that ambiguity.