Add interceptor methods: onNextRendering, onSnapshotTree #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pyricau
force-pushed
the
py/causal_traces
branch
2 times, most recently
from
181d348 to
73fbacc
Compare
workflow-core/src/commonMain/kotlin/com/squareup/workflow1/WorkerWorkflow.kt
Outdated
Show resolved
Hide resolved
...acing/src/main/java/com/squareup/workflow1/diagnostic/tracing/TimelineWorkflowInterceptor.kt
Outdated
Show resolved
Hide resolved
pyricau
force-pushed
the
py/causal_traces
branch
from
73fbacc to
baa8f1a
Compare
pyricau
commented
Feb 28, 2023
workflow-core/src/commonMain/kotlin/com/squareup/workflow1/Worker.kt
Outdated
Show resolved
Hide resolved
pyricau
commented
Feb 28, 2023
| override fun toString(): String = | ||
| WorkflowIdentifierTypeNamer.uniqueName(EmitWorkerOutputAction::class) + | ||
| "(worker=$worker, key=\"$renderKey\")" | ||
| "(worker=$worker, key=$renderKey)" |
There was a problem hiding this comment.
We typically don't use " in logged names.
pyricau
force-pushed
the
py/causal_traces
branch
3 times, most recently
from
9364383 to
16b82d6
Compare
pyricau
changed the title
pyricau
force-pushed
the
py/causal_traces
branch
from
16b82d6 to
7622589
Compare
rjrjr
approved these changes
Mar 2, 2023
| ): S = proceed(old, new, state) | ||
|
|
||
| /** | ||
| * Intercept calls to [com.squareup.workflow1.internal.WorkflowRunner.nextRendering]. |
There was a problem hiding this comment.
Suggested change
| * Intercept calls to [com.squareup.workflow1.internal.WorkflowRunner.nextRendering]. | |
| * Intercept calls to [WorkflowRunner.nextRendering][com.squareup.workflow1.internal.WorkflowRunner.nextRendering]. |
There was a problem hiding this comment.
This definitely needs kdoc here as we are intercepting an internal method in the Runner.
| ): S = proceed(old, new, state) | ||
|
|
||
| /** | ||
| * Intercept calls to [com.squareup.workflow1.internal.WorkflowRunner.nextRendering]. |
There was a problem hiding this comment.
This definitely needs kdoc here as we are intercepting an internal method in the Runner.
| /** | ||
| * Intercept calls to [StatefulWorkflow.snapshotState] including the children calls. | ||
| */ | ||
| public fun onSnapshotTree( |
There was a problem hiding this comment.
This is a bit confusing. Why not onSnapshotStateWithChildren? Also could use kdoc explaining use case.
pyricau
force-pushed
the
py/causal_traces
branch
from
7622589 to
6dd59b3
Compare
pyricau
commented
Mar 4, 2023
|
|
||
| override val realIdentifier: WorkflowIdentifier = unsnapshottableIdentifier(workerType) | ||
| override fun describeRealIdentifier(): String = "worker $workerType" | ||
| override fun describeRealIdentifier(): String = workerType.toString() |
There was a problem hiding this comment.
the workers have names that make it clear they're workers, no need for this.
pyricau
commented
Mar 4, 2023
| } | ||
| } | ||
|
|
||
| override fun toString() = debugString |
There was a problem hiding this comment.
Removing WorkflowNodeId(identifier=foo, name=bar) to just foo and foo named bar
|
Still would like to see a commit message explaining what use case this unlocked. |
steve-the-edwards
approved these changes
Mar 6, 2023
|
@pyricau you can use |
pyricau
force-pushed
the
py/causal_traces
branch
from
6dd59b3 to
53ae4eb
Compare
Also removing noise from some of the toString()
pyricau
force-pushed
the
py/causal_traces
branch
from
53ae4eb to
7ed7aff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removing noise from some of the toString()