update KtLint to 0.47.1 and switch KtLint-gradle to Kotlinter #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
approved these changes
Oct 27, 2022
RBusarow
force-pushed
the
rick/ktlint_kotlinter
branch
from
8499752 to
5747676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ktlint-gradleplugin is no longer being maintained and does not support any version of KtLint past0.45.2. Kotlinter is current. Kotlinter also happens to be faster and has nicer console output.These changes make us current with our internal ktlint settings and version.
The first commit shows my logic changes. The second commit's all automatic except for two cases of
@file:Suppress("ktlint:filename")where the rule is giving a false positive.