Deletes deprecated enterState and modifyState #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Oops, we're using |
rjrjr
force-pushed
the
rjrjr/no-enterState
branch
from
ce6242f to
40b7e47
Compare
A tiny bit of convenience, a lot of landmines.
rjrjr
force-pushed
the
rjrjr/no-enterState
branch
from
40b7e47 to
4a27e76
Compare
zach-klippenstein
approved these changes
Jun 30, 2020
Collaborator
zach-klippenstein
left a comment
zach-klippenstein
left a comment
There was a problem hiding this comment.
LG, but I'm a bit worried this is going to add a lot of unnecessary overhead to upgrading internally. Yes these have been deprecated for a while, and yes they're bad, but they're no more bad now than they were last month.
Collaborator
Author
|
I'll close it then. |
zach-klippenstein
added a commit
that referenced
this pull request
Feb 4, 2021
Move everything into a compose subdirectory to prep for importing into the main workflow-kotlin repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny bit of convenience, a lot of landmines.