Skip to content

No more hard coded EnvironmentScreen in WorkflowLayout. #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2022
Merged

No more hard coded EnvironmentScreen in WorkflowLayout. #840

merged 2 commits into from
Jul 26, 2022

Conversation

@rjrjr
Copy link
Collaborator

@rjrjr rjrjr commented Jul 20, 2022

WorkflowLayout was wrapping things in EnvironmentScreen for no real reason. No longer.

@rjrjr rjrjr force-pushed the ray/workflowlayout-tidying branch from 03423c5 to 070f105 Compare July 20, 2022 22:45
@rjrjr rjrjr changed the base branch from main to ray/better-bounds July 20, 2022 22:45
@rjrjr rjrjr force-pushed the ray/better-bounds branch from 8515f04 to 09fee95 Compare July 20, 2022 22:49
@rjrjr rjrjr force-pushed the ray/workflowlayout-tidying branch from 070f105 to 65163b6 Compare July 20, 2022 22:49
@rjrjr rjrjr force-pushed the ray/better-bounds branch from 09fee95 to f6204fe Compare July 20, 2022 23:09
@rjrjr rjrjr force-pushed the ray/workflowlayout-tidying branch from 65163b6 to c40ffa2 Compare July 20, 2022 23:09
@rjrjr
Copy link
Collaborator Author

rjrjr commented Jul 21, 2022

@steve-the-edwards This seems consistent, and I don't understand how it's possible. These changes are entirely on the view side.

renderPassCounterFrameTimeoutComplexNoInitializingStateHighFrequencyEvents

java.lang.AssertionError: Congrats! You have improved the the number of Render Passes (lower better) by 33 (37.50%) for Runtime: FrameTimeout; the 'Raven navigation (no initializing state) scenario with high frequency events'! Please update the expected value for your config. The value is now 55 (was 88..97).

@steve-the-edwards steve-the-edwards mentioned this pull request Jul 22, 2022
Open
@rjrjr rjrjr force-pushed the ray/workflowlayout-tidying branch 2 times, most recently from f7bbe69 to 0bb6fa2 Compare July 22, 2022 15:32
@rjrjr rjrjr marked this pull request as ready for review July 22, 2022 17:56
@rjrjr rjrjr requested review from a team and zach-klippenstein as code owners July 22, 2022 17:56
rjrjr added 2 commits July 22, 2022 13:43
@rjrjr
No more hard coded EnvironmentScreen in WorkflowLayout.
704244a 
WorkflowLayout was wrapping things in EnvironmentScreen for no real reason. No longer.
@rjrjr
renderPassCounterFrameTimeoutComplexNoInitializingStateHighFrequencyE…
8595fa9 
…vents flaky

See #841
@rjrjr rjrjr force-pushed the ray/better-bounds branch from f6204fe to d8ecc32 Compare July 22, 2022 20:43
@rjrjr rjrjr requested a review from a team as a code owner July 22, 2022 20:43
@rjrjr rjrjr force-pushed the ray/workflowlayout-tidying branch from 0bb6fa2 to 8595fa9 Compare July 22, 2022 20:43
@rjrjr rjrjr mentioned this pull request Jul 26, 2022
Merged
@rjrjr rjrjr merged commit f96fb8e into ray/better-bounds Jul 26, 2022
@rjrjr rjrjr deleted the ray/workflowlayout-tidying branch July 26, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steve-the-edwards steve-the-edwards steve-the-edwards approved these changes

@zach-klippenstein zach-klippenstein Awaiting requested review from zach-klippenstein

Assignees

@steve-the-edwards steve-the-edwards

@RBusarow RBusarow

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rjrjr @steve-the-edwards @RBusarow