Introduce unsnapshottableIdentifier() to allow transient WorkflowIdentifiers. #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-klippenstein
force-pushed
the
zachklipp/transient-workflowidentifiers
branch
2 times, most recently
from
10fc53c to
13f9a68
Compare
rjrjr
approved these changes
Jun 29, 2020
| * Returns a description of this identifier including the name of its workflow type and any | ||
| * [proxiedIdentifier]s. Computes [typeString] if it has not already been computed. | ||
| * If this identifier is snapshottable, returns the serialized form of the identifier. | ||
| * If it is not snapshottable, returns null. |
Collaborator
There was a problem hiding this comment.
This doesn't strike me as hacky at all.
workflow-core/src/main/java/com/squareup/workflow/WorkflowIdentifier.kt
Outdated
Show resolved
Hide resolved
…tifiers. This fixes #79 and unblocks the ability to implement GUWT Workers as Workflows. `WorkflowIdentifier` can now indicate that it is not serializable by returning null from `toByteString()`, in which case neither it nor the snapshot of the workflow it identifies will be serialized. Because these identifiers do not need to be serialized, they can contain arbitrary values such as `KType`s, which is how Workers distinguish themselves for example. Workers also do not need to be snapshotted, so this works out.
zach-klippenstein
force-pushed
the
zachklipp/transient-workflowidentifiers
branch
from
13f9a68 to
1a1eced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #79 and unblocks the ability to implement GUWT Workers as Workflows.
WorkflowIdentifiercan now indicate that it is not serializable by returningnull from
toByteString(), in which case neither it nor the snapshot of theworkflow it identifies will be serialized. Because these identifiers do not need
to be serialized, they can contain arbitrary values such as
KTypes, which ishow Workers distinguish themselves for example. Workers also do not need to
be snapshotted, so this works out.