Introduces ScreenViewFactory.forWrapper
#805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapping is finally as simple as it should be. Also moves `ScreenViewRunner` to a better home in `ScreenViewHolder.kt`.
rjrjr
force-pushed
the
ray/ScreenViewFactory-tweaks
branch
from
b270d25 to
8192497
Compare
steve-the-edwards
approved these changes
Jun 10, 2022
| * Environment.EMPTY + (ReverseNeutronFlowPolarity to true) | ||
| * ) | ||
| * } | ||
| * } |
There was a problem hiding this comment.
Awesome examples! Thank-you!
Comment on lines
+248
to
+251
| public inline fun < | ||
| reified WrapperT : Screen, | ||
| WrappedT : Screen | ||
| > forWrapper( |
There was a problem hiding this comment.
This formatting looks odd to me? Can we move the generics up on the same line and the function name too?
|
Uh oh, |
rjrjr
commented
Jun 14, 2022
Comment on lines
-356
to
-362
| public inline fun < | ||
| reified WrapperT : Screen, | ||
| WrappedT : Screen | ||
| > ScreenViewFactory<WrappedT>.toUnwrappingViewFactory( | ||
| crossinline unwrap: (wrapperScreen: WrapperT) -> WrappedT, | ||
| ): ScreenViewFactory<WrapperT> = | ||
| toUnwrappingViewFactory(unwrap) { _, ws, e, su -> su(unwrap(ws), e) } |
There was a problem hiding this comment.
I already regret deleting this, probably going to bring it back.
There was a problem hiding this comment.
Nope, still no use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping is finally as simple as it should be.
Also moves
ScreenViewRunnerto a better home inScreenViewHolder.kt.