Convert :workflow-runtime to KMM #799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bnvinay92
commented
Jun 2, 2022
bnvinay92
commented
- Replaces SendChannel#offer with SendChannel#trySend.
- org.jetbrains.kotlinx:kotlinx-coroutines-test:1.5.1 only ships a jvm artifact so bumped only this test dependency in commonTest to 1.6.1 (which ships artifacts for all platforms).
steve-the-edwards
approved these changes
Jun 2, 2022
There was a problem hiding this comment.
Thanks @bnvinay92 - this is so exciting!
LGTM. @RBusarow also to take a look as he is tracking along with these close.y
workflow-runtime/src/commonTest/kotlin/com/squareup/workflow1/RenderWorkflowInTest.kt
Outdated
Show resolved
Hide resolved
workflow-runtime/src/commonTest/kotlin/com/squareup/workflow1/RenderWorkflowInTest.kt
Outdated
Show resolved
Hide resolved
workflow-runtime/src/commonTest/kotlin/com/squareup/workflow1/internal/WorkflowRunnerTest.kt
Outdated
Show resolved
Hide resolved
RBusarow
approved these changes
Jun 2, 2022
There was a problem hiding this comment.
I had the same nitpicks as @steve-the-edwards, but overall this is great!
workflow-runtime/src/commonTest/kotlin/com/squareup/workflow1/internal/WorkflowRunnerTest.kt
Outdated
Show resolved
Hide resolved
bnvinay92
force-pushed
the
vn/p3-runtime
branch
2 times, most recently
from
68412bd to
9dca396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.