-
Notifications
You must be signed in to change notification settings - Fork 112
Convert :workflow-core to kmp #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! It looks great!
I ran this branch's snapshot through the CI on our main project and everything's green. So, as soon as we've added some KDoc to WorkflowIdentifierType, I can approve.
| @Suppress("UnstableApiUsage") | ||
| dependencyResolutionManagement { | ||
| repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS) | ||
| repositoriesMode.set(RepositoriesMode.PREFER_PROJECT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No big deal.
workflow-core/src/commonMain/kotlin/com/squareup/workflow1/WorkflowIdentifierType.kt
Show resolved
Hide resolved
Thanks. Added KDoc and removed the redundant dependency here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Rundown: