Hello ModalScreenOverlay #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
force-pushed
the
ray/default-modal-screen
branch
2 times, most recently
from
33dfa36 to
b9b1e3e
Compare
|
I've clicked Ready for Review and clocked out for the day, but I have to admit that I haven't actually seen the build go green yet. 🤞 |
rjrjr
force-pushed
the
ray/default-modal-screen
branch
from
b9b1e3e to
ebf1bab
Compare
|
Failure was a silly lint check. @RBusarow this is good to go. |
rjrjr
commented
Apr 15, 2022
| * ) { | ||
| * override fun buildDialogWithContentView(contentView: View): Dialog { | ||
| * return super.buildDialogWithContentView(contentView).also { | ||
| * // Whatever, man, go wild. For that matter don't feel obligated to call super. |
rjrjr
force-pushed
the
ray/default-modal-screen
branch
from
ebf1bab to
9ab18dc
Compare
RBusarow
approved these changes
Apr 15, 2022
|
|
||
| override val compatibilityKey: String get() = keyFor(content, "ScreenOverlay") | ||
| override val compatibilityKey: String | ||
| get() = keyFor(content, this::class.simpleName ?: "ScreenOverlay") |
There was a problem hiding this comment.
nit:
Suggested change
| get() = keyFor(content, this::class.simpleName ?: "ScreenOverlay") | |
| get() = keyFor(content, this::class.simpleName ?: ScreenOverlay::class.simpleName) |
There was a problem hiding this comment.
Have to put a !! on that, but 👍
- Adds `ModalScreenOverlay` - Makes `ModalScreenOverlayDialogFactory` non-abstract, and uses it for `ModalScreenOverlay` by default - Both `ModalScreenOverlayDialogFactory` and `AlertOverlayDialogFactory` are now public open classes, with kdoc explaining that they can be used as base classes for custom renderings. - Improves / corrects kdoc on `OverlayDialogFactoryFinder` and `ScreenViewFactoryFinder`, showing how to use them to customize built in rendering types. - Makes the `LoadingSpinner` in the benchmarked Poetry app use the new hotness, and fixes its animation in the process
rjrjr
force-pushed
the
ray/default-modal-screen
branch
from
9ab18dc to
24db899
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ModalScreenOverlayMakes
ModalScreenOverlayDialogFactorynon-abstract, and uses it forModalScreenOverlayby defaultBoth
ModalScreenOverlayDialogFactoryandAlertOverlayDialogFactoryare now public open classes, with kdoc explaining that they can be used as base classes for custom renderings.Improves / corrects kdoc on
OverlayDialogFactoryFinderandScreenViewFactoryFinder, showing how to use them to customize built in rendering types.Makes the
LoadingSpinnerin the benchmarked Poetry app use the new hotness, and fixes its animation in the process