Introduces WorkflowLayout.update. #638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
force-pushed
the
ray/open-up-wflayout
branch
from
e67c4ec to
0a8482b
Compare
rjrjr
commented
Jan 20, 2022
workflow-ui/core-android/src/main/java/com/squareup/workflow1/ui/WorkflowLayout.kt
Outdated
Show resolved
Hide resolved
We make the core `update` method for `WorkflowLayout` public to give apps complete control over how exactly they collect renderings. Doing this because the `takeWhileAttached` method used by `start` is causing problems. Opening this up lets those impacted by these problems avoid them. In a downstream release, we will upgrade `androidx.lifecycle:lifecycle-viewmodel` and update the convenient `start` to use its improved API. Details in #632.
rjrjr
force-pushed
the
ray/open-up-wflayout
branch
from
0a8482b to
904813e
Compare
RBusarow
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make the core
updatemethod forWorkflowLayoutpublic to give apps complete control over how exactly they collect renderings.Doing this because the
takeWhileAttachedmethod used bystartis causing problems. Opening this up lets those impacted by these problems avoid them. In a downstream release, we will upgradeandroidx.lifecycle:lifecycle-viewmodeland update the convenientstartmethod to use its improved API. Details in #632.