-
Notifications
You must be signed in to change notification settings - Fork 112
Upgrade the project to Kotlin 1.6.10.
#618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,10 +19,10 @@ object Dependencies { | |
|
|
||
| object Compose { | ||
| const val activity = "androidx.activity:activity-compose:1.3.1" | ||
| const val foundation = "androidx.compose.foundation:foundation:1.0.1" | ||
| const val material = "androidx.compose.material:material:1.0.1" | ||
| const val tooling = "androidx.compose.ui:ui-tooling:1.0.1" | ||
| const val ui = "androidx.compose.ui:ui:1.0.1" | ||
| const val foundation = "androidx.compose.foundation:foundation:1.1.0-rc01" | ||
| const val material = "androidx.compose.material:material:1.1.0-rc01" | ||
| const val tooling = "androidx.compose.ui:ui-tooling:1.1.0-rc01" | ||
| const val ui = "androidx.compose.ui:ui:1.1.0-rc01" | ||
| } | ||
|
|
||
| const val constraint_layout = "androidx.constraintlayout:constraintlayout:2.1.0" | ||
|
|
@@ -60,15 +60,15 @@ object Dependencies { | |
| const val timber = "com.jakewharton.timber:timber:4.7.1" | ||
|
|
||
| object Moshi { | ||
| const val adapters = "com.squareup.moshi:moshi-adapters:1.12.0" | ||
| const val codeGen = "com.squareup.moshi:moshi-kotlin-codegen:1.12.0" | ||
| const val moshi = "com.squareup.moshi:moshi:1.12.0" | ||
| const val adapters = "com.squareup.moshi:moshi-adapters:1.13.0" | ||
| const val codeGen = "com.squareup.moshi:moshi-kotlin-codegen:1.13.0" | ||
| const val moshi = "com.squareup.moshi:moshi:1.13.0" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To support Kotlin 1.6.10. |
||
| } | ||
|
|
||
| object Kotlin { | ||
| const val binaryCompatibilityValidatorPlugin = | ||
| "org.jetbrains.kotlinx:binary-compatibility-validator:0.6.0" | ||
| const val gradlePlugin = "org.jetbrains.kotlin:kotlin-gradle-plugin:1.5.21" | ||
| const val gradlePlugin = "org.jetbrains.kotlin:kotlin-gradle-plugin:1.6.10" | ||
|
|
||
| object Stdlib { | ||
| const val common = "org.jetbrains.kotlin:kotlin-stdlib-common" | ||
|
|
@@ -85,11 +85,11 @@ object Dependencies { | |
| const val test = "org.jetbrains.kotlinx:kotlinx-coroutines-test:1.5.1" | ||
| } | ||
|
|
||
| const val reflect = "org.jetbrains.kotlin:kotlin-reflect:1.5.21" | ||
| const val reflect = "org.jetbrains.kotlin:kotlin-reflect:1.6.10" | ||
|
|
||
| object Serialization { | ||
| const val gradlePlugin = "org.jetbrains.kotlin:kotlin-serialization:1.5.20" | ||
| const val json = "org.jetbrains.kotlinx:kotlinx-serialization-json:1.2.2" | ||
| const val gradlePlugin = "org.jetbrains.kotlin:kotlin-serialization:1.6.10" | ||
| const val json = "org.jetbrains.kotlinx:kotlinx-serialization-json:1.3.2" | ||
| } | ||
|
|
||
| object Test { | ||
|
|
@@ -101,7 +101,7 @@ object Dependencies { | |
| } | ||
| } | ||
|
|
||
| const val dokka = "org.jetbrains.dokka:dokka-gradle-plugin:1.4.32" // 1.5.0? | ||
| const val dokka = "org.jetbrains.dokka:dokka-gradle-plugin:1.5.31" | ||
|
|
||
| object Jmh { | ||
| const val gradlePlugin = "me.champeau.gradle:jmh-gradle-plugin:0.5.3" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,6 +42,7 @@ typealias RunGameScreen = AlertContainerScreen<PanelContainerScreen<Any, Any>> | |
| * We define this otherwise redundant typealias to keep composite workflows | ||
| * that build on [RunGameWorkflow] decoupled from it, for ease of testing. | ||
| */ | ||
| @OptIn(WorkflowUiExperimentalApi::class) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't see why this is needed, possible b/c of the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The compiler is more strict. It's needed even with the other change. |
||
| typealias RunGameWorkflow = Workflow<Unit, RunGameResult, RunGameScreen> | ||
|
|
||
| /** | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is the latest version for these libraries, but there's an
rc02for the compiler plugin with Kotlin 1.6.10 support. We'll use the same versions internally very soon.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you file an issue tracking this, and add a comment here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#619