Skip to content

Fixes index out of bounds crash in hello-todo-terminal sample #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2021
Merged

Fixes index out of bounds crash in hello-todo-terminal sample #605

merged 1 commit into from
Dec 10, 2021

Conversation

@JsFlo
Copy link
Contributor

@JsFlo JsFlo commented Dec 10, 2021 •
edited
Loading

Fixes index out of bounds crash when attempting to add characters or moving the cursor to the ends of the string being edited.

  • uses setOutput to cause the parent workflow to update the string when adding characters
  • coerces cursor position within the 0..text.length

Fixes issue: #516

@JsFlo
Fixes index out of bounds crash when attempting to add characters or …
5931b4a 
…moving the cursor to the ends of the string being edited.
@JsFlo JsFlo requested review from a team and zach-klippenstein as code owners December 10, 2021 04:05
@CLAassistant
Copy link

CLAassistant commented Dec 10, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rjrjr
Copy link
Collaborator

rjrjr commented Dec 10, 2021

Thank you!

steve-the-edwards
steve-the-edwards approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@steve-the-edwards steve-the-edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rjrjr rjrjr merged commit 821c7b6 into square:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjrjr rjrjr rjrjr approved these changes

@steve-the-edwards steve-the-edwards steve-the-edwards approved these changes

@zach-klippenstein zach-klippenstein Awaiting requested review from zach-klippenstein zach-klippenstein is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JsFlo @CLAassistant @rjrjr @steve-the-edwards