Skip to content

Renames WithEnvironment to EnvironmentScreen. #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2021
Merged

Renames WithEnvironment to EnvironmentScreen. #587

merged 1 commit into from
Nov 17, 2021

Conversation

@rjrjr
Copy link
Collaborator

@rjrjr rjrjr commented Nov 17, 2021

Fixes #585.

@rjrjr rjrjr requested review from a team and zach-klippenstein as code owners November 17, 2021 00:54
bencochran
bencochran approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@bencochran bencochran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m a fan! (but you already knew that 😇)

steve-the-edwards
steve-the-edwards approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@steve-the-edwards steve-the-edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer WithEnvironment - but you already knew that 😝

@rjrjr
Copy link
Collaborator Author

rjrjr commented Nov 17, 2021

I prefer WithEnvironment - but you already knew that 😝

I kept Screen.withEnvironment() and Screen.withRegistry() at least.

@rjrjr rjrjr merged commit 57595af into ray/ui-update Nov 17, 2021
@rjrjr rjrjr deleted the ray/environmentScreen branch November 17, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steve-the-edwards steve-the-edwards steve-the-edwards approved these changes

@zach-klippenstein zach-klippenstein Awaiting requested review from zach-klippenstein

+1 more reviewer

@bencochran bencochran bencochran approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@steve-the-edwards steve-the-edwards

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rjrjr @bencochran @steve-the-edwards