Skip to content

Disables HelloWorkflowFragmentAppTest on API 21 b/c LeakCanary #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Disables HelloWorkflowFragmentAppTest on API 21 b/c LeakCanary #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4565c2
Disables HelloWorkflowFragmentAppTest on API 21 b/c LeakCanary
rjrjr Nov 9, 2021
53cf69d
Suppresses lifecycle_replace_after_pause on API 21
rjrjr Nov 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...ndroidTest/java/com/squareup/sample/helloworkflowfragment/HelloWorkflowFragmentAppTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,23 @@
package com.squareup.sample.helloworkflowfragment

import android.os.Build
import androidx.test.espresso.action.ViewActions.click
import androidx.test.espresso.assertion.ViewAssertions.matches
import androidx.test.espresso.matcher.ViewMatchers.isDisplayed
import androidx.test.espresso.matcher.ViewMatchers.withText
import androidx.test.ext.junit.rules.ActivityScenarioRule
import androidx.test.ext.junit.runners.AndroidJUnit4
import androidx.test.filters.SdkSuppress
import com.squareup.workflow1.ui.WorkflowUiExperimentalApi
import com.squareup.workflow1.ui.internal.test.inAnyView
import org.hamcrest.Matchers.containsString
import org.junit.Rule
import org.junit.Test
import org.junit.runner.RunWith

// Life is too short to debug why LeakCanary breaks this on API 21
// https://github.com/square/workflow-kotlin/issues/582
@SdkSuppress(minSdkVersion = Build.VERSION_CODES.M)
@RunWith(AndroidJUnit4::class)
@OptIn(WorkflowUiExperimentalApi::class)
class HelloWorkflowFragmentAppTest {
Expand Down
19 changes: 19 additions & 0 deletions ...kflow-fragment/src/androidTest/java/com/squareup/sample/helloworkflowfragment/StubTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package com.squareup.sample.helloworkflowfragment

import androidx.test.ext.junit.runners.AndroidJUnit4
import com.squareup.workflow1.ui.WorkflowUiExperimentalApi
import org.junit.Test
import org.junit.runner.RunWith

/**
* Stub test to avoid failing b/c no tests when suppressing [HelloWorkflowFragmentAppTest]
* on API 21.
*
* https://github.com/square/workflow-kotlin/issues/582
*/
@RunWith(AndroidJUnit4::class)
@OptIn(WorkflowUiExperimentalApi::class)
class StubTest {
@Test fun fml() {
}
}
4 changes: 4 additions & 0 deletions ...d/src/androidTest/java/com/squareup/workflow1/ui/backstack/test/BackstackContainerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
package com.squareup.workflow1.ui.backstack.test

import android.os.Build
import android.view.View
import androidx.lifecycle.Lifecycle.State.CREATED
import androidx.lifecycle.Lifecycle.State.RESUMED
import androidx.lifecycle.Lifecycle.State.STARTED
import androidx.test.ext.junit.rules.ActivityScenarioRule
import androidx.test.filters.SdkSuppress
import com.google.common.truth.Truth.assertThat
import com.squareup.workflow1.ui.WorkflowUiExperimentalApi
import com.squareup.workflow1.ui.backstack.test.fixtures.BackStackContainerLifecycleActivity
Expand Down Expand Up @@ -339,6 +341,8 @@ internal class BackstackContainerTest {
}
}

// https://github.com/square/workflow-kotlin/issues/559
@SdkSuppress(minSdkVersion = Build.VERSION_CODES.M)
@Test fun lifecycle_replace_after_pause() {
assertThat(scenario.state).isEqualTo(RESUMED)
scenario.onActivity {
Expand Down