262: Deprecate Worker.createSideEffect in favour of RenderContext.run… #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
requested review from
a team and
zach-klippenstein
as code owners
steve-the-edwards
force-pushed
the
sedwards/deprecate-create-side-effect
branch
from
7be9bf9 to
539c4c8
Compare
…ningSideEffect Replace with runningSideEffect where possible or with a Worker<Unit> instead of Worker<Nothing>.
steve-the-edwards
force-pushed
the
sedwards/deprecate-create-side-effect
branch
from
539c4c8 to
d09bf20
Compare
Co-authored-by: Ray Ryan <[email protected]>
Contributor
Author
|
I think the CI instrumentation was timing out on other PRs as well right @zach-klippenstein ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ningSideEffect
Replace with runningSideEffect where possible or with a Worker instead of
Worker.
Closes #262