Introduces AndroidViewRendering, de-emphasizes ViewRegistry #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rjrjr
force-pushed
the
ray/shorter-path-to-ViewRendering
branch
from
7ac619d to
727ab92
Compare
rjrjr
commented
Nov 19, 2020
workflow-ui/core-android/src/main/java/com/squareup/workflow1/ui/ViewRegistry.kt
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
workflow-ui/core-android/src/main/java/com/squareup/workflow1/ui/AndroidViewContainer.kt
Outdated
Show resolved
Hide resolved
workflow-ui/core-android/src/main/java/com/squareup/workflow1/ui/AndroidViewContainer.kt
Outdated
Show resolved
Hide resolved
workflow-ui/core-common/src/main/java/com/squareup/workflow1/ui/ViewRendering.kt
Outdated
Show resolved
Hide resolved
rjrjr
force-pushed
the
ray/shorter-path-to-ViewRendering
branch
from
727ab92 to
4e63f72
Compare
rjrjr
changed the title
rjrjr
force-pushed
the
ray/shorter-path-to-ViewRendering
branch
7 times, most recently
from
8a2ef20 to
9ec46e7
Compare
rjrjr
commented
Nov 20, 2020
samples/containers/app-poetry/src/main/java/com/squareup/sample/poetryapp/PoemListView.kt
Outdated
Show resolved
Hide resolved
rjrjr
force-pushed
the
ray/shorter-path-to-ViewRendering
branch
5 times, most recently
from
e9cc34f to
48a52bb
Compare
zach-klippenstein
approved these changes
Nov 20, 2020
samples/containers/app-poetry/src/main/java/com/squareup/sample/poetryapp/PoemListView.kt
Outdated
Show resolved
Hide resolved
workflow-ui/core-android/src/main/java/com/squareup/workflow1/ui/AndroidViewRendering.kt
Outdated
Show resolved
Hide resolved
rjrjr
force-pushed
the
ray/shorter-path-to-ViewRendering
branch
from
48a52bb to
28f96d0
Compare
Collaborator
Author
|
Update renames *View back to *Rendering. |
rjrjr
force-pushed
the
ray/shorter-path-to-ViewRendering
branch
from
28f96d0 to
e49d9a9
Compare
Collaborator
Author
|
Rebasing, rebasing, I can't keep up with Zach! |
`AndroidViewRendering` is implemented by renderings that can provide their own `ViewFactory`. `ViewRegistry.buildView` looks to see if a given rendering implements that method if it fails to find an entry for it -- note that we look for a registration first, so `ViewRegistry` is able override the default. Given this, it's no longer crucial for developers to define and provide a `ViewRegistry`, so we get rid of all the nannying that forced them to provide one. Updates the samples to use the new interface and drop their `ViewRegistry` instances where possible.
rjrjr
force-pushed
the
ray/shorter-path-to-ViewRendering
branch
from
e49d9a9 to
efb518b
Compare
Contributor
steve-the-edwards
left a comment
steve-the-edwards
left a comment
There was a problem hiding this comment.
Cool; will this be the first in a category of "Platform"ViewRendering interfaces do you think>
Collaborator
|
The idea was always for workflow to be able to support different ui frameworks. That doesn't change with this. Although we don't have any immediate plans to implement support for other ones at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AndroidViewRenderingis implemented by renderings that can provide their ownViewFactory.ViewRegistry.buildViewlooks to see if a given renderingimplements that method if it fails to find an entry for it -- note that we
look for a registration first, so
ViewRegistryis able override the default.Given this, it's no longer crucial for developers to define and provide a
ViewRegistry, so we get rid of all the nannying that forced them to provideone.
Updates the samples to use the new interface and drop their
ViewRegistryinstances where possible.