Use telephoto for panning and zooming #1421
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
|
saket
commented
Sep 5, 2025
| rememberZoomableState( | ||
| zoomSpec = ZoomSpec(maxZoomFactor = 1f) | ||
| ).also { | ||
| it.contentScale = ContentScale.Fit |
Collaborator
Author
There was a problem hiding this comment.
It might be worth exploring ContentScale.Crop for large traces
Contributor
|
@saket sorry I need to take a look to see why the I did add you to the team list for this repo so I thought that would in the mean time workaround the write perms issue, but it seems it is not 😕 . |
japplin
force-pushed
the
japplin/workflow-visualizer-title
branch
from
0a2acb4 to
84cffb0
Compare
Contributor
|
I did not expect merging my other branch to close this branch 😬 . I'll try to rebase the branch and reopen against main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #1417 (comment)
This PR removes all custom pointer handlers in
SandboxBackground()so thatModifier.zoomable()can take care of both panning and zooming.One change to call out is that zooming with the mouse scroll now behaves differently. Previously, you were using scroll alone, but telephoto uses
Option+ scroll by default to match the behavior of other macOS apps. If you prefer the old behavior, you can change this if you want by writing a custom HardwareShortcutsSpec.It might be a good idea to display all shortcuts somewhere in the UI. Here's what telephoto uses:
https://saket.github.io/telephoto/zoomable/#keyboard-shortcuts
Your app actually helped uncover a few bugs in
telephoto, which historically hasn't been well optimized for non-Android targets. Some worth mentioning:Zoom using keyboard and mouse shortcuts is currently broken because
telephotois miscalculating zoom factors. I'll push a fix soon.Overzoom doesn't look great right now. I'll disable it for hardware shortcuts in a future release.
CleanShot.2025-09-05.at.15.57.01.mp4