Skip to content

Fix PhoneWindow.superDispatchTouchEvent NullPointerException #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

Fix PhoneWindow.superDispatchTouchEvent NullPointerException #1402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions workflow-ui/core-android/src/main/java/com/squareup/workflow1/ui/navigation/DialogSession.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,15 @@ internal class DialogSession(
val was = field
field = value
holder.dialog.window?.takeIf { value != was }?.let { window ->
// https://stackoverflow.com/questions/2886407/dealing-with-rapid-tapping-on-buttons
// If any motion events were enqueued on the main thread, cancel them.
dispatchCancelEvent { window.superDispatchTouchEvent(it) }
// When we cancel, have to warn things like RecyclerView that handle streams
// of motion events and eventually dispatch input events (click, key pressed, etc.)
// based on them.
window.peekDecorView()?.cancelPendingInputEvents()
window.peekDecorView()?.let { decorView ->
// https://stackoverflow.com/questions/2886407/dealing-with-rapid-tapping-on-buttons
// If any motion events were enqueued on the main thread, cancel them.
dispatchCancelEvent { window.superDispatchTouchEvent(it) }
// When we cancel, have to warn things like RecyclerView that handle streams
// of motion events and eventually dispatch input events (click, key pressed, etc.)
// based on them.
decorView.cancelPendingInputEvents()
}
}
}

Expand Down
Loading