Remove Compose Dependency from Android Runtime #1379
Conversation
steve-the-edwards
requested review from
a team and
zach-klippenstein
as code owners
| * for Workflow. | ||
| * synchronously). We recommend using a `CoroutineDispatcher` in this scope's `CoroutineContext` | ||
| * that will ensure that all dispatched coroutines are run before the next Choreographer frame. | ||
| * Compose UI's `AndroidUiDispatcher.Main` provides this behavior in a performant way! |
There was a problem hiding this comment.
Should update all the compose samples to demonstrate.
There was a problem hiding this comment.
- Could also mention that compose apps can use
Workflow.renderAsStateto sidestep thinking about this. Too much? - Did we ever extend
renderAsStateto allow a config to be passed in?
There was a problem hiding this comment.
That's a good point about the samples!
There was a problem hiding this comment.
Did we ever extend renderAsState to allow a config to be passed in?
I don't think so!
There was a problem hiding this comment.
Did we ever extend renderAsState to allow a config to be passed in?
Turns out we did. It takes the scope by default from rememberCoroutineScope() which will take it from Compose which will likely be AndroidUiDispatcher.Main on Android.
| ): StateFlow<RenderingT> { | ||
| val restoredSnap = savedStateHandle?.get<PickledTreesnapshot>(KEY)?.snapshot | ||
|
|
||
| // Add in Compose's AndroidUiDispatcher.Main by default if none is specified. |
There was a problem hiding this comment.
Would it be too magical to use reflection to look for AndroidUiDispatcher.Main and default to it if available?
There was a problem hiding this comment.
I think probably?
steve-the-edwards
force-pushed
the
sedwards/remove-compose-requirement
branch
from
f21e1d6 to
6fb83b3
Compare
steve-the-edwards
force-pushed
the
sedwards/remove-compose-requirement
branch
from
6fb83b3 to
d4acbf6
Compare
steve-the-edwards
force-pushed
the
sedwards/remove-compose-requirement
branch
from
d4acbf6 to
bd09ff7
Compare
No description provided.