Make RenderingProduced not a value class. #1372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Value classes get boxed as soon as they're used as a supertype, so it's basically pointless to make sealed class children value classes. I made it a data class instead. This change is required to move `:workflow-runtime-android` into `:workflow-runtime`, or we get a compiler crash. I also made the object siblings data objects to fix a compiler suggestion and get better `toString` methods.
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rjrjr
reviewed
Jul 16, 2025
| * the runtime produces a rendering. | ||
| */ | ||
| public object RenderPassSkipped : RuntimeUpdate | ||
| public data object RenderPassSkipped : RuntimeUpdate |
There was a problem hiding this comment.
We avoid using data in public API, remember? Seems like this would be fine as just object / class.
There was a problem hiding this comment.
The arguments for not using data classes in public API don't apply to objects, since they contain no data by definition.
And the data class was previously a value class, which is even more impossible to change than a data class, so this is no more constrained.
rjrjr
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value classes get boxed as soon as they're used as a supertype, so it's basically pointless to make sealed class children value classes. I made it a data class instead.
This change is required to move
:workflow-runtime-androidinto:workflow-runtime, or we get a compiler crash.I also made the object siblings data objects to fix a compiler suggestion and get better
toStringmethods.