Workflow Visualizer UX improvements

[wenli-cai]

1. Allow each node to be opened and closed to ignore irrelevant information for each frame. Nodes that were directly affected in the specific render pass, though, are all open by default, and everything else is closed by default.

2. Allow for using a mouse's vertical scroll to traverse through the row of frames.

[steve-the-edwards]

Neat.

[steve-the-edwards]

oh nice. Ok i see you moved to reflection here. that's great. I think it makes sense.

[zach-klippenstein]

Is there a particular reason you need this animation to outlive the pointerInput modifier's lifetime? It would be slightly cleaner to just wrap this with coroutineScope {}, i.e.

Suggested change

	.pointerInput(Unit) {
	awaitEachGesture {
	val event = awaitPointerEvent()
	if (event.type == PointerEventType.Scroll) {
	val scrollDeltaY = event.changes.first().scrollDelta.y
	coroutineScope.launch {
	lazyListState.scroll(MutatePriority.Default) {
	scrollBy(scrollDeltaY * 10f)
	}
	}
	}
	}
	},
	.pointerInput(Unit) {
	coroutineScope {
	awaitEachGesture {
	val event = awaitPointerEvent()
	if (event.type == PointerEventType.Scroll) {
	val scrollDeltaY = event.changes.first().scrollDelta.y
	launch {
	lazyListState.scroll(MutatePriority.Default) {
	scrollBy(scrollDeltaY * 10f)
	}
	}
	}
	}
	}
	},

[wenli-cai]

Changed

[zach-klippenstein]

This is a weird little bit of backwards data flow. Feels like there should be a presenter or something handling this?

It also looks like affectedNodes and expandedNodes effectively represent the same thing, since this code just synchronizes them, or partially synchronizes them? It's possible I'm misunderstanding the code.

[wenli-cai]

1. I'm not familiar with using a Presenter as a pattern, if you wouldn't mind explaining a potential solution (or point me to a resource). I can understand that UI should be using callbacks to affect data rather than directly mutating it, but when I experimented hoisting everything out of this Composable and into RenderDiagram, the tree would no longer recompose everytime I open/closed a node.

   But I definitely could've been trying an incorrect way of doing it, leading it to fail.

2. Any affectedNodes for the specific renderpass will always be the same, but the nodes that are expanded can be changed. So we can open a non-affected node, and we can also close an affected node