Move non-ui Android RenderWorkflow concerns to workflow-runtime-android #1352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
requested review from
a team and
zach-klippenstein
as code owners
steve-the-edwards
force-pushed
the
sedwards/move-render-2
branch
2 times, most recently
from
7dd05cf to
95bf5b8
Compare
zach-klippenstein
approved these changes
Jun 23, 2025
| class PoetryModel(savedState: SavedStateHandle) : ViewModel() { | ||
| val renderings: Flow<Screen> by lazy { | ||
| renderWorkflowIn( | ||
| com.squareup.workflow1.android.renderWorkflowIn( |
Collaborator
There was a problem hiding this comment.
Nit: You're already statically importing this, I think the FQN is just an IDE bug? Search-and-replace to fix?
steve-the-edwards
force-pushed
the
sedwards/move-render-android
branch
from
21e5929 to
3eac67c
Compare
steve-the-edwards
force-pushed
the
sedwards/move-render-2
branch
from
95bf5b8 to
90af5aa
Compare
steve-the-edwards
force-pushed
the
sedwards/move-render-2
branch
from
90af5aa to
225a91f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a
workflow-runtime-androidmodule (and published artifact), it is the place that makes sense to hold the Android versions ofrenderWorkflowIn, as they are beyond solely UI concerns, so do not need to be inworkflow-ui.Yes, I recognize that we could distribute this as an Android library from the
workflow-runtimeKMP module with a particular sourceset as well as particular publishing.I think that would be a good thing to do, but I don't want to figure out how to set that up right now. I think our balance of jvm, ios, and js artifacts from the KMP modules right now makes sense. I do not think we lose anything from this Android library being a standalone module (after all, it was before when it was in
workflow-ui).