1338: Clean up caches after WorkflowNode torn down #1339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // No other cleanup work should be done in this function, since it will only be invoked when | ||
| // this workflow is *directly* discarded by its parent (or the host). | ||
| // If you need to do something whenever this workflow is torn down, add it to the | ||
| // invokeOnCompletion handler for the Job above. |
There was a problem hiding this comment.
This comment was old. We now cancel anytime we stop actively rendering a node.
zach-klippenstein
approved these changes
Jun 10, 2025
|
|
||
| /** | ||
| * When we are finished with at least one node that holds on to this workflow instance, | ||
| * then we clear the cache. The reason we do that every time is that it *might* be the last |
There was a problem hiding this comment.
Just gonna say, this sounds like a problem for refcounting, although if this is a temporary bandaid while we prep for a bigger, more comprehensive fix, who cares.
rjrjr
approved these changes
Jun 10, 2025
steve-the-edwards
force-pushed
the
sedwards/render-context-leak
branch
from
4f14d12 to
cdf8890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1338