Revert "Update expectRemember to provide result" #1333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
approved these changes
May 30, 2025
steve-the-edwards
force-pushed
the
ray/forget-it
branch
from
75f37eb to
9bb54a2
Compare
- This change forced us to provide an `expectRemember` call for every `remember` call - Under `STABLE_EVENT_HANDLERS` that means every `eventHandler` call, clearly impractical - So we could change it to allow providing an option of returning alternative value from the remember call, but default to run the real calculation; but we have found no use cases for that - So were just going back to the original implementation This reverts commit fa75ef8.
steve-the-edwards
force-pushed
the
ray/forget-it
branch
from
9bb54a2 to
48374e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expectRemembercall for everyremembercallSTABLE_EVENT_HANDLERSthat means everyeventHandlercall, clearly impracticalThis reverts commit fa75ef8.