Make RenderTester throw a more realistic exception if the same workflow/side effect is ran twice. #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow/side effect is ran twice. It now throws an exception that looks just like the real runtime. This doesn't _fail_ the test, it _errors_ it, which is also better behavior since this case means the workflow-under-test is written incorrectly, not that it doesn't match expected test behavior. Fixes #120. This change also cleans up the way `WorkflowIdentifier`s are described in error and testing strings, unifies the impostor and non-impostor calls, makes the string consistent between runtime and tests, and removes a method from the public API.
|
|
||
| public final class com/squareup/workflow1/WorkflowIdentifier { | ||
| public static final field Companion Lcom/squareup/workflow1/WorkflowIdentifier$Companion; | ||
| public final fun describeRealIdentifier ()Ljava/lang/String; |
Collaborator
Author
There was a problem hiding this comment.
Yay one less public method!
rjrjr
approved these changes
Jul 13, 2020
| proxiedIdentifiers | ||
| .joinToString { it.typeName } | ||
| .let { "WorkflowIdentifier($it)" } | ||
| description?.invoke() |
Collaborator
There was a problem hiding this comment.
First time I've seen an unambiguously good reason to use invoke()
Collaborator
Author
|
Both UI tests timed out. This has been happening more and more, we might need to increase the timeouts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now throws an exception that looks just like the real runtime. This doesn't fail the test,
it errors it, which is also better behavior since this case means the workflow-under-test is
written incorrectly, not that it doesn't match expected test behavior. Fixes #120.
This change also cleans up the way
WorkflowIdentifiers are described in error and testing strings,unifies the impostor and non-impostor calls, makes the string consistent between runtime and tests,
and removes a method from the public API.