Add an extension on TextController that returns a mutable state of TextFieldValue

[darshanparajuli]

While asMutableState() extension already exists, it works with String and does not preserve selection ranges. TextController.asMutableTextFieldValueState() returns a mutable state of TextFieldValue, making it easy to integrate TextController with text fields.

[rjrjr]

• Could you also update the existing sample usages of the String-based one to use this instead? When I sketched that last month everything worked nicely, tests continued to pass.

• Keith argued that we should keep both since the String one is a simpler alternative. WDYT about deprecating the old one instead?

[rjrjr]

Here's where I played with the samples: #1291 Oh, nevermind, I guess I never pushed that.

[darshanparajuli]

Keith argued that we should keep both since the String one is a simpler alternative. WDYT about deprecating the old one instead?

As I understand it, the primary purpose of TextController.asMutableState() is to be used with text fields in compose. Therefore, I think String version can be deprecated in favor of TextFieldValue.

If you only care about String, then you just access .text property:

var foo by fooTextController.asMutableTextFieldValueState()
doStuff(foo.text) // String

Also, I think you mostly care about wanting a String when reading from it rather than writing to it, right? Especially since the write sources are text fields, in which case we do care about selections. Worst case:

var foo by fooTextController.asMutableTextFieldValueState()
SomeTextField(
  value = foo.text,
  onValueChanged = { newString -> foo = TextFieldValue(newString, TextRange(newString.length)) }
)

I admit ☝️ is less ergonomic, but I imagine there are very few use cases like that.

[rjrjr]

That all makes sense to me.

• Could you go ahead and deprecate the old one in this PR?

[darshanparajuli]

That all makes sense to me.

• Could you go ahead and deprecate the old one in this PR?

done!

[rjrjr]

You'll need to update the api spec:

./gradlew workflow-core:apiDump  workflow-ui:core-android:apiDump  workflow-ui:core-common:apiDump workflow-ui:internal-testing-android:apiDump workflow-ui:internal-testing-compose:apiDump workflow-ui:compose:apiDump workflow-ui:compose-tooling:apiDump workflow-runtime:apiDump workflow-testing:apiDump

[darshanparajuli]

You'll need to update the api spec:

./gradlew workflow-core:apiDump  workflow-ui:core-android:apiDump  workflow-ui:core-common:apiDump workflow-ui:internal-testing-android:apiDump workflow-ui:internal-testing-compose:apiDump workflow-ui:compose:apiDump workflow-ui:compose-tooling:apiDump workflow-runtime:apiDump workflow-testing:apiDump

Thanks! forgot about that.

[rjrjr]

Sorry the CI jobs weren't running, they should from now on.