Makes DialogCollator handle redundant scheduleUpdate calls.
#1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
force-pushed
the
ray/ComposeView-DialogCollator-Fight
branch
from
1f84fa1 to
cdf6418
Compare
If we have nested `ComposeView` instances they can trigger redundant updates from their `onAttachedToWindow()` hooks. When `DialogCollator` gets duplicate calls from `BodyAndOverlaysContainer` in that situation it throws away earlier ones to avoid creating duplicate `Dialog` windows when `doUpdate()` fires.
rjrjr
force-pushed
the
ray/ComposeView-DialogCollator-Fight
branch
from
cdf6418 to
c30044e
Compare
steve-the-edwards
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have nested
ComposeViewinstances they can trigger redundant updates from theironAttachedToWindow()hooks. WhenDialogCollatorgets duplicate calls fromBodyAndOverlaysContainerin that situation it throws away earlier ones to avoid creating duplicateDialogwindows whendoUpdate()fires.