Skip to content

Extract public interface methods with default implementations into extension methods. #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2020
Merged

Extract public interface methods with default implementations into extension methods. #127

merged 1 commit into from
Jul 13, 2020

Conversation

@zach-klippenstein
Copy link
Collaborator

@zach-klippenstein zach-klippenstein commented Jul 13, 2020

Closes #118.

@zach-klippenstein zach-klippenstein added this to the v1.0.0 milestone Jul 13, 2020
@zach-klippenstein zach-klippenstein requested a review from a team as a code owner July 13, 2020 19:58
rjrjr
rjrjr reviewed Jul 13, 2020
View reviewed changes
workflow-testing/src/test/java/com/squareup/workflow1/testing/RealRenderTesterTest.kt
}
workflow.testRender(Unit)
.expectWorkflow<Nothing, Unit>(
.expectWorkflow(
Copy link
Collaborator

@rjrjr rjrjr Jul 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@zach-klippenstein zach-klippenstein merged commit 35d2beb into main Jul 13, 2020
@zach-klippenstein zach-klippenstein deleted the zachklipp/extract-default-methods branch July 13, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjrjr rjrjr rjrjr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

Convert non-essential methods from interfaces to extension functions

3 participants

@zach-klippenstein @rjrjr