-
Notifications
You must be signed in to change notification settings - Fork 112
1247: Partial Tree Rerendering #1248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
72aa1c9
1247: Partial Tree Rerendering
steve-the-edwards c14c54d
Update workflow-runtime/src/commonMain/kotlin/com/squareup/workflow1/…
steve-the-edwards 8e5d20a
Update workflow-runtime/src/commonMain/kotlin/com/squareup/workflow1/…
steve-the-edwards 7d3a6fe
Update workflow-runtime/src/commonMain/kotlin/com/squareup/workflow1/…
steve-the-edwards File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
workflow-core/src/commonMain/kotlin/com/squareup/workflow1/NullableInitBox.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package com.squareup.workflow1 | ||
|
|
||
| import kotlin.jvm.JvmInline | ||
|
|
||
| /** | ||
| * Used to wrap immutable nullable values whose holder may not yet be initialized. | ||
| * Check [isInitialized] to see if the value has been assigned. | ||
| */ | ||
| @JvmInline | ||
| public value class NullableInitBox<T>(private val _value: Any? = Uninitialized) { | ||
| /** | ||
| * Whether or not a value has been set for this [NullableInitBox] | ||
| */ | ||
| public val isInitialized: Boolean get() = _value !== Uninitialized | ||
|
|
||
| /** | ||
| * Get the value this has been initialized with. | ||
| * | ||
| * @throws [IllegalStateException] if the value in the box has not been initialized. | ||
| */ | ||
| @Suppress("UNCHECKED_CAST") | ||
| public fun getOrThrow(): T { | ||
| check(isInitialized) { "NullableInitBox was fetched before it was initialized with a value." } | ||
| return _value as T | ||
| } | ||
|
|
||
| public object Uninitialized | ||
| } | ||
41 changes: 41 additions & 0 deletions
41
workflow-core/src/commonTest/kotlin/com/squareup/workflow1/NullableInitBoxTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| package com.squareup.workflow1 | ||
|
|
||
| import kotlin.test.Test | ||
| import kotlin.test.assertEquals | ||
| import kotlin.test.assertFailsWith | ||
| import kotlin.test.assertFalse | ||
| import kotlin.test.assertTrue | ||
|
|
||
| class NullableInitBoxTest { | ||
|
|
||
| @Test fun reports_not_initialized() { | ||
| val box = NullableInitBox<String>() | ||
|
|
||
| assertFalse(box.isInitialized) | ||
| } | ||
|
|
||
| @Test fun reports_initialized() { | ||
| val box = NullableInitBox<String>("Hello") | ||
|
|
||
| assertTrue(box.isInitialized) | ||
| } | ||
|
|
||
| @Test fun returns_value() { | ||
| val box = NullableInitBox<String>("Hello") | ||
|
|
||
| assertEquals("Hello", box.getOrThrow()) | ||
| } | ||
|
|
||
| @Test fun throws_exceptions() { | ||
| val box = NullableInitBox<String>() | ||
|
|
||
| val exception = assertFailsWith<IllegalStateException> { | ||
| box.getOrThrow() | ||
| } | ||
|
|
||
| assertEquals( | ||
| "NullableInitBox was fetched before it was initialized with a value.", | ||
| exception.message | ||
| ) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't take in at first that this is a
value class. Cool!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a @zach-klippenstein special when we were noodling on this.