Update to Kotlin 1.9.24, w/ corresponding Compose, KSP #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
requested review from
a team and
zach-klippenstein
as code owners
steve-the-edwards
force-pushed
the
sedwards/update-versions
branch
from
ad894ae to
036c8b8
Compare
steve-the-edwards
changed the title
steve-the-edwards
force-pushed
the
sedwards/update-versions
branch
2 times, most recently
from
8004eaa to
ec62f2d
Compare
zach-klippenstein
approved these changes
Dec 16, 2024
| event.changes.forEach { change -> | ||
| if (change.pressed != change.previousPressed) change.consume() | ||
| private fun Modifier.disableTouchInput(): Modifier = | ||
| then( |
Collaborator
There was a problem hiding this comment.
You don't need then when calling other modifier factories that already properly chain. This actually ends up calling then twice which i'm surprised doesn't have negtive side effects.
Contributor
Author
There was a problem hiding this comment.
it was giving me a lint error though for not calling then 🤔 . Maybe i need to try again.
Contributor
Author
There was a problem hiding this comment.
nvm, must have been in an older version of the refactor I had done. No warning/lint now!
| childLifecycleOwner = rememberChildLifecycleOwner(parentLifecycle) | ||
| CompositionLocalProvider(LocalLifecycleOwner provides childLifecycleOwner) { | ||
| CompositionLocalProvider( | ||
| androidx.lifecycle.compose.LocalLifecycleOwner provides childLifecycleOwner |
Collaborator
There was a problem hiding this comment.
Why remove this import?
Contributor
Author
There was a problem hiding this comment.
just didn't get the import in after the change to the androidx.lifecycle version. will add.
steve-the-edwards
force-pushed
the
sedwards/update-versions
branch
from
ec62f2d to
6e59250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kotlin and KSP 1.9.24
compose compiler - 1.5.14
compose bom - 2024.09.02
androidx.lifecycle to 2.8.1