Remove Deprecated Worker, eventHandler, and action APIs #1237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
requested review from
a team and
zach-klippenstein
as code owners
steve-the-edwards
force-pushed
the
sedwards/remove-anon
branch
from
380be87 to
bf1154f
Compare
| // to immediately resume on suspension inside block when it is crossinline. | ||
| // See https://youtrack.jetbrains.com/issue/KT-31197. | ||
| noinline block: suspend () -> OutputT? | ||
| crossinline block: suspend () -> OutputT? |
There was a problem hiding this comment.
Also changed this to crossinline as that issue was fixed a number of years ago.
| * TODO: https://github.com/square/workflow-kotlin/issues/526 once this is removed. | ||
| */ | ||
| @Suppress("DEPRECATION") | ||
| public fun Completable.asWorker(): Worker<Nothing> = Worker.createSideEffect { await() } |
There was a problem hiding this comment.
One would just use
runningSideEffect { myCompletable.await() }
steve-the-edwards
force-pushed
the
sedwards/remove-anon
branch
from
bf1154f to
960818c
Compare
zach-klippenstein
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some have been long deprecated, others more recently deprecated (the anonymous actions and eventHandlers - but we have not received any concerns regarding removing them - #1236, https://workflow-community.slack.com/archives/CHTFPR277/p1732635078961279?thread_ts=1730740915.096009&cid=CHTFPR277)
Also, prefix
eventHandlerdebuggingNames witheH: