Introduces SavedStateHandle.removeWorkflowState()
#1227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
force-pushed
the
ray/scrub-viewmodel-state
branch
from
12b674c to
2625d26
Compare
rjrjr
force-pushed
the
ray/scrub-viewmodel-state
branch
from
2625d26 to
34d2f95
Compare
tcmulcahy
approved these changes
Nov 5, 2024
rjrjr
force-pushed
the
ray/scrub-viewmodel-state
branch
from
34d2f95 to
b1dd821
Compare
If you're juggling multiple workflow runtimes per `Activity` (if you're the kind of person who needs to call `Job.cancel` on the `Job` returned from `WorkflowLayout.take`) then you might also need to throw away the state captured by an AndroidX `SavedStateHandler` passed to the Android flavor of `renderWorkflowIn()` to prevent memory leaks.
rjrjr
force-pushed
the
ray/scrub-viewmodel-state
branch
from
b1dd821 to
c905ad1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're juggling multiple workflow runtimes per
Activity(if you're the kind of person who needs to callJob.cancelon theJobreturned fromWorkflowLayout.take) then you might also need to throw away the state captured by an AndroidXSavedStateHandlerpassed to the Android flavor ofrenderWorkflowIn()to prevent memory leaks.