Makes TextController support equals
#1224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
LGTM, but could you add a unit test? |
jkwiz
force-pushed
the
joshwilliams/text-controller-equals
branch
from
47d58ca to
df5471e
Compare
rjrjr
approved these changes
Oct 21, 2024
workflow-ui/core-common/src/test/java/com/squareup/workflow1/ui/TextControllerTest.kt
Outdated
Show resolved
Hide resolved
jkwiz
force-pushed
the
joshwilliams/text-controller-equals
branch
from
df5471e to
59d76c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows comparing
TextControllerby the currenttextValue.