BREAKING: container > navigation #1154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
commented
Jan 17, 2024
samples/containers/poetry/src/main/java/com/squareup/sample/poetry/StanzaListScreen.kt
Outdated
Show resolved
Hide resolved
rjrjr
force-pushed
the
ray/container-is-navigation
branch
3 times, most recently
from
51083d9 to
7f37cfc
Compare
rjrjr
force-pushed
the
ray/container-is-navigation
branch
from
7f37cfc to
ed2ecc4
Compare
Collaborator
Author
|
Force push fixes file name of |
ijwhelan
approved these changes
Jan 18, 2024
Collaborator
ijwhelan
left a comment
ijwhelan
left a comment
There was a problem hiding this comment.
Overall LGTM, just one place where Android Studio tried to be too helpful
...s/nested-overlays/src/main/java/com/squareup/sample/nestedoverlays/NestedOverlaysWorkflow.kt
Outdated
Show resolved
Hide resolved
rjrjr
force-pushed
the
ray/container-is-navigation
branch
from
ed2ecc4 to
0937f6d
Compare
In preparation for (finally!) locking down the workflow-ui API, renames the `com.squareup.workflow1.ui.container` package to `navigation`, since that's the common theme of nearly everything in there. I think this simple change should help make our navigation story a bit more self documentating. Yes, I'll still write navigation docs. Other changes: * `View.setBackHandler` moves from `ui` to `ui.navigation` * `EnvironmentScreen`, `Screen.withEnvironment()`, `Screen.withRegistry()` which this PR moves up to the `ui` package. References to these had bled out into other spots already, so this feels like a move in the right direction. * `OnBackPressedDispatcherOwnerKey` moves from `ui` to `ui.androidx` Also, note that the packages of the deprecated classes in the `container-android` and `container-common` modules were not changed, since they're about to be deleted.
rjrjr
force-pushed
the
ray/container-is-navigation
branch
from
0937f6d to
6ccfc5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for (finally!) locking down the workflow-ui API, renames the
com.squareup.workflow1.ui.containerpackage tonavigation, since that's the common theme of nearly everything in there. I think this simple change should help make our navigation story a bit more self documentating. Yes, I'll still write navigation docs.Other changes:
View.setBackHandlermoves fromuitoui.navigationEnvironmentScreen,Screen.withEnvironment(),Screen.withRegistry()which this PR moves up to theuipackage. References to these had bled out into other spots already, so this feels like a move in the right direction.OnBackPressedDispatcherOwnerKeymoves fromuitoui.androidxAlso, note that the packages of the deprecated classes in the
container-androidandcontainer-commonmodules were not changed, since they're about to be deleted.