BREAKING: Stop stomping View.layoutParams, new parameter for replaceViewInParent
#1135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
force-pushed
the
ray/do-not-stomp-bounds
branch
2 times, most recently
from
b03aeec to
df6b71a
Compare
rjrjr
changed the title
View.layoutParamsView.layoutParams
rjrjr
force-pushed
the
ray/do-not-stomp-bounds
branch
2 times, most recently
from
b820047 to
db1ef11
Compare
rjrjr
changed the title
View.layoutParamsView.layoutParams
traviswestbrook
approved these changes
Nov 15, 2023
ijwhelan
approved these changes
Nov 15, 2023
workflow-ui/core-android/src/main/java/com/squareup/workflow1/ui/WorkflowViewStub.kt
Outdated
Show resolved
Hide resolved
rjrjr
force-pushed
the
ray/do-not-stomp-bounds
branch
from
db1ef11 to
17c412c
Compare
|
Renamed to |
…ceViewInParent` `WorkflowViewStub.replaceViewInParent` now can be configured not to propagate `layoutParams`, by setting new property `propagatesLayoutParams` to `false`. When it's `true` (the default), the stub's `layoutParams` are passed as a new third argument to the (customizable) `replaceViewInParent` function, to make it clearer that this function bears responsibility for applying them. Motivated because `BodyAndOverlaysContainer` and `WorkflowLayout` were being dictatorial about the body view's layout params for no clear reason, leading to layout surprises. They're the first to opt out of `propagatesLayoutParams`.
rjrjr
force-pushed
the
ray/do-not-stomp-bounds
branch
from
17c412c to
b11e61e
Compare
rjrjr
changed the title
View.layoutParamsView.layoutParams, new parameter for replaceViewInParent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorkflowViewStub.replaceViewInParentnow can be configured not to propagatelayoutParams, by setting new propertypropagatesLayoutParamstofalse. When it'strue(the default), the stub'slayoutParamsare passed as a new third argument to the (customizable)replaceViewInParentfunction, to make it clearer that this function bears responsibility for applying them.Motivated because
BodyAndOverlaysContainerandWorkflowLayoutwere being dictatorial about the body view's layout params for no clear reason, leading to layout surprises. They're the first to opt out ofpropagatesLayoutParams.