Makes BackStackScreen<*> practical
#1121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
force-pushed
the
ray/tighten-up-backstack-types
branch
from
a3c37ee to
d1c5c4a
Compare
Adds a few crucial `out` declarations to various `Container` and `Wrapper` types, so that declaring `RenderingT` types like `BackStackScreen<*>` is practical. Also required moving `fun BackStackScreen.plus` out to be an extension function.
Without these changes, this does not compile:
```kotlin
val foo = BackStackScreen(FooScreen(1))
val bar = BackStackScreen(BarScreen(1))
val both = foo + bar
```
Instead we were forced to do things like:
```kotlin
val foo: BackStackScreen<Screen> = BackStackScreen(FooScreen(1))
val bar: BackStackScreen<Screen> = BackStackScreen(BarScreen(1))
val both = foo + bar
```
It gets really old really fast.
rjrjr
force-pushed
the
ray/tighten-up-backstack-types
branch
from
d1c5c4a to
927c038
Compare
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ijwhelan
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few crucial
outdeclarations to variousContainerandWrappertypes, so that declaringRenderingTtypes likeBackStackScreen<*>is practical. Also required movingfun BackStackScreen.plusout to be an extension function.Without these changes, this does not compile:
Instead we were forced to do things like:
It gets really old really fast.