Friendlier construction API for BackStackScreen
#1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Actually…let me update this to have a fundamental private constructor that just takes a list. It'll be more efficient and the public API will still prevent mistakes. |
rjrjr
force-pushed
the
ray/buildView-deprecation-tweak
branch
3 times, most recently
from
8d9522a to
ba6caa1
Compare
* Deprecates the confusing `bottom: T, rest: List` constructor * Adds `fromList` and `fromListOrNull` factory functions to `BackStackScreen.Companion`, since no one ever finds the `List` extensions
rjrjr
force-pushed
the
ray/buildView-deprecation-tweak
branch
from
ba6caa1 to
5d385ce
Compare
wardellbagby
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bottom, rest: Listconstructor with an eye toward making it privatefromListandfromListOrNullfactory functions toBackStackScreen.Companion, since no one ever finds theListextensionsWe'll preserve the
bottom, rest: Listconstructor as the core one because it makes it impossible to build an invalid instance.